Member ActsFatrasWriteHandler::createHits (const ISF::ISFParticle &isp, std::shared_ptr< const Acts::TrackingGeometry > trackingGeometry, const std::vector< ActsFatras::Hit > &hits, SiHitCollection &pixelSiHits, SiHitCollection &sctSiHits) const

: fix edge effects

Member ActsTrk::ActsToTrkConverterTool::appendMeasTSOS (const EventContext &ctx, const xAOD::UncalibratedMeasurement *meas, const TrkTSOSMask typePattern, Trk::FitQualityOnSurface &&quality, std::unique_ptr< Trk::TrackParameters > trkPars, Trk::TrackStates &states) const

Check whether the phi surface is in front of the eta surface

Class AthRNGSvc

Move from manual pointer management to smart pointer management.

Member BeamHaloGeneratorAlg::genInitialize ()

Use ServiceHandle system instead

Class BoxEnvelope

TODO needs documentation

Class CaloCluster

Class CaloTowerGeometry

Allow regional grids (varying segmentation as function of \( \eta \) . This requires additional interfaces (or interface changes) and and modifications of the index construction.

Member ChargedTracksFilter::ChargedTracksFilter (const std::string &name, ISvcLocator *pSvcLocator)

Document

Member CheckFlow_New.CheckFlow_New

Migrate to a GenBase class or at least AthAlgorithm

Member cmpGenParticleByEDesc (HepMC::ConstGenParticlePtr a, HepMC::ConstGenParticlePtr b)

Move into GeneratorUtils (with many friends)

Member columnar::ColumnarOffsetType

This type still needs to be adjusted to match whatever uproot uses for its offset maps.

Class ConstantFieldSvc

Needs documentation

Member CountHepMC::execute (const EventContext &ctx) override

Replace the old event ?

Member CP::AsgViewFromSelectionAlg::m_selection

this would probably better be an std::map, but this isn't supported as a property type for AnaAlgorithm right now

Member CscCalibTool::findCharge (const float samplingTime, const unsigned int samplingPhase, const std::vector< float > &samples, double &charge, double &time) const override final

find out if a larger range can be used, such as +-1.0

Class CylindricalEnvelope

TODO needs documentation

Class DetectorGeometryBase

NEEDS DOCUMENTATION

Class EfexDefs

FIXME These initial mappings are surely wrong: SJH 07/07/21 tried to get it right

Class EL::AnaAlgorithm

This class does not allow to do everything that can currently be done with a `EL::Algorithm` since it neither knows about incidents, nor has all the virtual methods that were available before.

Class EL::DuplicateChecker

add documentation

Class FCS_Param::FCS_StepInfoSDTool

Add more details.

Class G4AtlasRunManager

sync and reduce code duplication with MT run managers.

Member G4FieldManagerToolBase::m_fieldOn

TODO why is this duplicated in the g4 field svc?

Struct G4UA::CaloG4::CalibrationDefaultProcessing::Config

We really don't need a struct for a single string...

Class G4UA::G4AtlasEventAction

TODO lifetime management of wrapper actions.

Class G4UA::G4AtlasPrimaryGeneratorAction

TODO lifetime management of wrapper actions.

Class G4UA::G4AtlasRunAction

TODO lifetime management of wrapper actions.

Class G4UA::G4AtlasStackingAction

TODO lifetime management of wrapper actions.

Class G4UA::G4AtlasSteppingAction

TODO lifetime management of wrapper actions.

Class G4UA::G4AtlasTrackingAction

TODO lifetime management of wrapper actions.

Member G4UA::MomentumConservation::EndOfEventAction (const G4Event *) override

Does G4PrimaryParticle really have no Get(Total/Kinetic)Energy methods?

Do we need to add up the total energy at the start?

Everything! Use truth strategy as for neutrinos

Member G4UA::MomentumConservation::UserSteppingAction (const G4Step *) override

Should this be GetKineticEnergy?

Class G4UA::ScoringPlane

TODO NEEDS DOCUMENTATION

Member GenFilter::execute (const EventContext &ctx)

Probably the filter should only look at the first event... right?

Member GenModule::execute (const EventContext &ctx)

Remove hard-coded alg name checking (already incomplete)

Class Geo2G4Svc

NEEDS DOCUMENTATION

Class Geo2G4SvcBase

NEEDS DOCUMENTATION

Member HeavyFlavorHadronFilter::filterEvent (const EventContext &ctx)

This could be so much more efficient! And with so much less code duplication...

This could be so much more efficient!

Member Herwig7::fillEvt (HepMC::GenEvent *evt)

Conversion to HepMC format will possibly be provided by the authors as part of a higher-level API.

Member Herwig7::genFinalize ()

Think of other way to wait for all access to terminate

Member Herwig7::genInitialize ()

Higher-level API to be provided by the Herwig authors to allow for slimmer interface and for usage of more advanced features such as the setupfile mechanism for modifying existing runfiles.

Member Herwig7Config.Hw7Config.global_pre_commands (self)

Remove AngularOrdered settungs once they are included in Herwig7 by default

Member Herwig7ConfigFxFx.Hw7ConfigFxFx.fxfx_commands (self, merging_scale, njets_max, lhe_filename="events.lhe", me_pdf_order="NLO", r_clus=1.0, eta_clus_max=15.0, usespin=True, automatic_process_detection=True, ihrd=None, ihvy=None)

Settings which are not FxFx-specific should be identical to the LHEF showering of MG5_aMC@NLO events. This should probably be enforced in some way

Remove ihrd and ihvy parameters beginning with Herwig 7.1.0 since the hard process will be deduced automatically

Member Herwig7ConfigMatchbox.Hw7ConfigMatchbox.do_integrate (self, integration_job)

provide info about the range

Member Herwig7ConfigMerging.Hw7ConfigMerging.do_integrate (self, integration_job)

provide info about the range

Class High2LowByGenParticleClassPt

Move to a sorting utils module

Member iFatras::HitCreatorSilicon::createSimHit (const ISF::ISFParticle &isp, const Trk::TrackParameters &pars, double time, const InDetDD::SiDetectorElement &hitSiDetElement, bool isSiDetElement) const

: fix edge effects

Member iFatras::HitCreatorTRT::createSimHit (const ISF::ISFParticle &isp, const Trk::TrackParameters &, double) const

: fill information, decide which one is pre/post step point

Member iFatras::McMaterialEffectsUpdator::recordBremPhoton (double time, double pElectron, double gammaE, const Amg::Vector3D &vertex, Amg::Vector3D &particleDir, Trk::ParticleHypothesis particle) const

fix non-static

Member iGeant4::G4LegacyTransportTool::releaseEvent (const EventContext &, HitCollectionMap &) override

: strip hits of the tracks ...

Member iGeant4::G4TransportTool::releaseEvent (const EventContext &, HitCollectionMap &) override

: strip hits of the tracks ...

Member IMuonHoughPatternTool::DeclareInterfaceID (IMuonHoughPatternTool, 1, 0)

should be rethought and possibly using the Moore Interface

Member InDet::TRT_DriftCircleOnTrack::globalPosition () const override final

convention about z coordinate

fullfills Trk::MeasurementBase interface

Class ISF::G4PolyconeGeoIDSvc

Member ISF::G4PolyconeGeoIDSvc::m_volume [AtlasDetDescr::fNumAtlasRegions]

:

Member ISF::G4PolyconeGeoIDSvc::pushDimension (AtlasDetDescr::AtlasRegion geoID, double rin, double rou, double z)

Member ISF::G4PolyconeGeoIDSvc::pushDimension (AtlasDetDescr::AtlasRegion geoID, double r, double z)

Class ISF::ITruthStrategy

: class description

Member JetFilter::filterEvent (const EventContext &ctx)

Use MCPID to identify leptons

Page LArCalibTools

Page LArCalibUtils

Class LArWheelCalculator_Impl::DistanceCalculatorFactory

Why is this a class???

Member LArWheelCalculator_Impl::rotate_to_nearest_fan (const LArWheelCalculator *lwc, int &fan_number, const double angle, CLHEP::Hep3Vector &p)

Needs documentation

Member LVL1::Coordinate::checkBounds ()

Tidy up and finish

Class LVL1::CoordToHardware

this should probably be a static class.

Member LVL1::CoordToHardware::cpRoIROD (const Coordinate &coord)

check that this is still correct - it seems sensible but hasn't be formally defined

Member LVL1::CoordToHardware::jepModule (const Coordinate &coord)

IMPLEMENT

Class LVL1::CPRoIDecoder

this should probably be a static class.

Class LVL1::JEPRoIDecoder

this should probably be a static class.

Class LVL1::JetEtRoIDecoder

this should probably be a static class.

Member LVL1::JetROI::roiWord () const

implement hardware coords in ROI word

Member LVL1::JetROI::saturated () const

implement

Member LVL1::JetROI::thresholdType (int threshold_number) const

implement

Class LVL1::L1METvalue

this should probably be a static class.

Class LVL1::QuadLinear

this should probably be a static class.

Member LVL1::RecEmTauRoI::triggerThreshold (unsigned int thresh) const

Thresholds can vary by coordinate. Return value which matches coord of RecRoI

Class LVL1::RoIDecoder

this should probably be a static class.

Class LVNotifier

NEEDS DOCUMENTATION

Member MissingETBase::Types::objlink_vector_t

Check behaviour of ElementLinkVector<xAOD::IParticleContainer> if incomplete ElementLink<xAOD::IParticleContainer> may exist!

Member Muon::CscClusterOnTrack::setValues (const Trk::TrkDetElementBase *, const Trk::PrepRawData *) override final

Throw exception if TrkDetElementBase isn't correct concrete type

Member Muon::CscStripPrepData::CscStripPrepData (const Identifier &RDOId, const IdentifierHash &collectionHash, const Amg::Vector2D &locpos, const Amg::MatrixX &locErrMat, const MuonGM::CscReadoutElement *detEl, const std::vector< float > &sampleCharges, float timeOfFirstSample, unsigned short samplingRate)

More info.

Member Muon::IMDT_RDOtoByteStreamTool::convert (const MdtCsmContainer *cont, MsgStream &log) const =0

Do we really need to pass in a logfile? This is a AlgTool and so can provide its own log objects.

Member Muon::MdtDriftCircleOnTrack::idDE () const override final

Remove

Member Muon::MMClusterOnTrack::setValues (const Trk::TrkDetElementBase *, const Trk::PrepRawData *)

Throw exception if TrkDetElementBase isn't correct concrete type

Member Muon::MuonPRD_Collection_p2::m_id

Ideally we wouldn't write this out, and would get the Id from the hash, but this doesn't seem to be easy to do with the current MdtIdHelper.

Member Muon::MuonTrackScoringTool::m_trkSummaryTool

make this const, once createSummary method is const

Member Muon::RpcClusterOnTrack::setValues (const Trk::TrkDetElementBase *, const Trk::PrepRawData *) override final

Throw exception if TrkDetElementBase isn't correct concrete type

Member Muon::sTgcClusterOnTrack::setValues (const Trk::TrkDetElementBase *, const Trk::PrepRawData *) override final

Throw exception if TrkDetElementBase isn't correct concrete type

Member Muon::TgcCablingMap::getReadoutIDRanges (int &maxRodId, int &maxSRodId, int &maxSswId, int &maxSbloc, int &minChannelId, int &maxChannelId) const

Tobe ported

Member Muon::TgcClusterOnTrack::setValues (const Trk::TrkDetElementBase *, const Trk::PrepRawData *)

Throw exception if TrkDetElementBase isn't correct concrete type

Member MuonHoughPatternTool::maxLevelHoughPattern (const MuonHoughPatternContainerShip &houghpattern, int id_number) const

should be in houghpattern?

Member MuonMatchingTool::extTrackToPivot (const EventContext &ctx, const xAOD::TrackParticle *track) const

Return std::unique_ptr when this is available.

Member MuonMatchingTool::match (const OFFL *offl, std::string trigger, float reqdR, bool &pass, const std::string &containerSGKey="", std::tuple< bool, double, double >(*trigPosForMatchFunc)(const T *)=&MuonMatchingTool::trigPosForMatch< T >) const

Consider improving the argument list.

Member MuonMatchingTool::matchLinkInfo (const OFFL *offl, std::string trigger, float reqdR, bool &pass, const std::string &containerSGKey="", std::tuple< bool, double, double >(*trigPosForMatchFunc)(const T *)=&MuonMatchingTool::trigPosForMatch< T >) const

Consider improving the argument list.

Member MuonMatchingTool::matchOff (const EventContext &ctx, const T *trig, float reqdR, std::tuple< bool, double, double >(*offlinePosForMatchFunc)(const xAOD::Muon *), std::tuple< bool, double, double >(*trigPosForMatchFunc)(const T *)=&MuonMatchingTool::trigPosForMatch< T >) const

Consider improving the argument list.

Member MuonMatchingTool::matchReadHandle (const OFFL *offl, float reqdR, SG::ReadHandleKey< DataVector< T > > ReadHandleKey, const EventContext &ctx, std::tuple< bool, double, double >(*trigPosForMatchFunc)(const T *)=&MuonMatchingTool::trigPosForMatch< T >) const

Consider improving the argument list.

Member MuonMatchingTool::searchFastRecoSALinkInfo (const xAOD::Muon *mu, std::string trigger) const

Consider improving the argument list.

Member MuonMatchingTool::searchL2CBLinkInfo (const xAOD::Muon *mu, std::string trigger) const

Consider improving the argument list.

Member MuonMatchingTool::searchL2SALinkInfo (const xAOD::Muon *mu, std::string trigger) const

Consider improving the argument list.

Member MuonR4::NswSegmentFinderAlg::markHitsAsUsed (const HitVec &spacePoints, const HitLayVec &allSortHits, UsedHitMarker_t &usedHitMarker, unsigned int increase, bool markNeighborHits) const

use the localMeasurementPos of the measurement?

Class ORUtils::MuJetOverlapTool

TODO document all the new properties!

Class ORUtils::ToolBox

Add some more usage details.

Member ParabolaCscClusterFitter::fit (const StripFitList &sfits, double dposdz) const

Remove this useless test.

check segment finding efficiency with Y pos = strip number.

Base errors on error propagation in parabola.

Check errors against residuals.

Check for saturation and increase errors.

Check for large amps and increase errors.

Check for small amps and increase errors.

Check cluster profile for overlapping hits.

Member ParabolaCscClusterFitter::getCorrectedError (const Muon::CscPrepData *pclu, double slope) const

Read, understand, and verify correctness. @pclu The CSC Prep Data for the cluster @slope The track angle

Member PileupTruthParticleSlimmer::PileupTruthParticleSlimmer (const std::string &name, ISvcLocator *svcLoc)

TruthParticle -> TruthParticles

Class PileUpType

Move this elsewhere – it does not implement the GenAccessIO API.

Class PolyconicalEnvelope

TODO needs documentation

Member PrintMC::execute (const EventContext &ctx) override

Avoid use of unprotected std::cout: stringstream + MsgStream would be better

I get the feeling VerboseOutput is being abused here...

Looks like misuse of the verbose output flag

Isn't this if (m_VerboseOutput... redundant?

Is there no better way to detect unspecified masses than == 0? Final state photons should be 0

Namespace PyJobTransforms.trfFileUtils

make functions timelimited

Member QCDTruthJetFilter::fitFn (const double x)

Move to an inline in the cc

Member QCDTruthJetFilter::fitFnR (const double *x, const double *)

Move to an inline in the cc

Member QCDTruthMultiJetFilter::fitFn (const double x)

Move to an inline in the cc

Member QCDTruthMultiJetFilter::fitFnR (const double *x, const double *)

Move to an inline in the cc

Member Rivet_i::execute (const EventContext &ctx) override

Replace with new GenBase functionality

Actually use back(), for the most recent event, or throw an exception if more than one event found?

Replace with new GenBase const_event() functionality

Member SimTimeEstimate::execute (const EventContext &ctx) override

Use C++ for(:)

Member Simulation::GenEventBeamEffectBooster::m_beam1ParticleMass

Get from a service

Member Simulation::GenEventBeamEffectBooster::m_pbeam2

Get from a service

Class TauolaPP

Convert to use standard GenModule base class

Class TestHepMC

Inherit from GenFilter? It is a filter

Member TestHepMC::execute (const EventContext &ctx)

Clean up / improve / apply to all decaying species

Persuade generator authors to set proper generated masses in HepMC, then really require mass = 0

Member TestHepMC::m_thistSvc

Can we use the GenAnalysis / AthHistoAlg methods for histo management?

File ThreadLocalHolder.h

Should we optimize these implementations for non-MT environments? One could alternatively just optimze the clients where necessary. I could replace these classes with a simple pointer wrapper if ATHENAHIVE and G4MULTITHREADED are not defined, but the map iteration functionality would need an awkward implementation.

Page TileCalibAlgs

Most of the algorithms need to be updated to the latest best knowledge of calibration constant calculation. While doing this more detailed documentation will be provided. For the current status of the package a detailed documentation would not make much sense.

Page TileCalibAlgs

Most of the algorithms need to be updated to the latest best knowledge of calibration constant calculation. While doing this more detailed documentation will be provided. For the current status of the package a detailed documentation would not make much sense.

Class TrigMuonMonitorAlgorithm

Support monitoring algorithms using truth muons

Member Trk::AmbiguityProcessorBase::m_scoringTool

The actual tool that is used should be configured through job options

Class Trk::AnnulusBounds

can be speed optimized, inner radius check in inside() can be optimized

Class Trk::Charged

Do we really need a double for the charge? Would an int be sufficient?

Member Trk::CompoundLayerMaterial::material (size_t bin0, size_t bin1) const override final

measure if this is slow

Member Trk::CompoundLayerMaterial::operator*= (double scale) override final

implement

Member Trk::ConeSurface::measurementFrame (const Amg::Vector3D &glopos, const Amg::Vector3D &glomom) const override final

fold in alpha

Class Trk::CylinderBounds

update the documentation picture for cylinder segments

Class Trk::CylinderSurface

update for new Possibility of CylinderBounds

Member Trk::DenseEnvironmentsAmbiguityScoreProcessorTool::m_scoringTool

The actual tool that is used should be configured through job options

Member Trk::DetectorType

work out how to add muons to this

Member Trk::GlueVolumesDescriptor::registerGlueVolumes (BoundarySurfaceFace, std::vector< TrackingVolume * > &)

change to addGlueVolumes principle

Class Trk::LocalDirection

add image of Jean-Francois

Member Trk::MaterialProperties::addMaterial (const Material &mp, float dInX0)

update ?

Member Trk::ReFitTrack::execute (const EventContext &ctx)

: include sorting of outliers

Member Trk::SectoralBevelledCylinderAccessorType

implement correcly when needed

Member Trk::SectoralCylinderAccessorType

implement correcly when needed

Member Trk::SectoralTubeAccessorType

implement correcly when needed

Member Trk::TrackParticleBase::fitQuality () const

Is this correct? Is it valid to have a TPB with no FQ?

Member Trk::TrackSelectionProcessorTool::m_scoringTool

The actual tool that is used should be configured through job options

Class Trk::TrapezoidBounds

can be speed optimized by calculating kappa/delta and caching it

Member Trk::TruthTrackBuilder::createTrack (const PRD_TruthTrajectory &prdTraj, SegmentCollection *segs=0) const

: if we need a dedicated electron fitter is has to go in here !

Class Trk::VertexMapper

add option to also map onto non-sensitive layers

Member TRT_ToT_dEdx::correctToT_corrRZ (const EventContext &ctx, const Trk::TrackStateOnSurface *itr, double length) const

implement possiblity to set the scaling factor run-by-run from database, should probably be done later on track- level

Member TRT_ToT_dEdx::mass (const EventContext &ctx, const Trk::TrackStateOnSurface *itr, const double pTrk, double dEdx) const

make failsafe

Member TRT_ToT_dEdx::predictdEdx (const EventContext &ctx, EGasType gasType, const double pTrk, Trk::ParticleHypothesis hypothesis) const

why is it possible that a 20 MeV particle reaches this point? (see Savannah bug 94644)

Member TTbarMassFilter::filterEvent (const EventContext &ctx)

How generator-portable is this status code assumption?

Member VBFMjjIntervalFilter::checkOverlap (double, double, const std::vector< HepMC::ConstGenParticlePtr > &) const

Provide a helper function for this (and similar)

Member VBFMjjIntervalFilter::checkOverlap (double, double, const std::vector< TLorentzVector > &) const

Provide a helper function for this (and similar)

Member WebdaqInfoSvc::getPublicationMutex () const override

Adopt this in TrigLArNoiseBurstRecoAlg, which still uses a private mutex, once the legacy service is retired. TrigExISPublishing already uses it. The mutex would become unnecessary overloading endEvent(ptree, fullName) in hltinterface, identifying the caller's object. Each producer would then touch only its own container and a private mutex would suffices. A cleaner alternative would be locking inside GenericHLTContainer. But this would require changing the accessors that are currently handing out raw references The hltinterface change should also drop const from getPublicationMutex(): returning a non-const reference from a const method forces the workaround below.

Member xAOD::AUXSTORE_OBJECT_SETTER_AND_GETTER (TruthEvent_v1, std::vector< float >, weights, setWeights) AUXSTORE_PRIMITIVE_SETTER_AND_GETTER(TruthEvent_v1

Need upgrade to allow string-valued map-like access... or access a corresponding vector of names

Member xAOD::BPhysHelper::pv (const pv_type vertexType=BPhysHelper::PV_MIN_A0)

: In case the refitted vertices are augmented with links to the original primary vertices, method origPv will resolve the links and return the original PVs.

Member xAOD::Muon_v1::clusterLink () const

Why just one?

Member xAOD::Muon_v1::muonSegmentLinks () const

complete the various calo energy additions (i.e. depositInCalo etc)

Member xAOD::Muon_v1::muonType () const

Add documentation. Generic accessor to type information.

Member xAOD::Muon_v1::parameter (float &value, const ParamDef parameter) const

Finish documentation include matchChi2, muonentrancechi2 (instead of outerMatchChi2). Store chi2/dof instead of two? fitChi2 comes from TrackParticle.

Member xAOD::Muon_v1::setMuonType (MuonType type)